TrinityCore / WowPacketParser

World of Warcraft Packet Parser
GNU General Public License v3.0
410 stars 352 forks source link

Fixed SMSG_PLAYER_CHOICE_CLEAR struct for 10.0.7 #768

Closed SargeroDeV closed 9 months ago

SargeroDeV commented 1 year ago

ToDo:

Shauren commented 1 year ago

In my opinion new structures with all fields "unk" arent very useful

SargeroDeV commented 1 year ago

In my opinion new structures with all fields "unk" arent very useful

My opinion is different from yours, because I do not play in Retail, so I am not the one who makes the sniffs, I simply take a sniff and open my IDA, I look for its structure and then I test it in the parser, I know that an unnamed structure has no use to work in the core directly, but I give the possibility that any contributor who plays in Retail and does not know Reverse Engineering himself can take that structure and according to his sniff data he can rename the fields.

Shauren commented 1 year ago

Ah but you see, thats the issue here, you don't guess names based on sniff data but rather by what client does with them - so your imaginary contributor (that will be doing the rename) still needs to know how to reverse

SargeroDeV commented 1 year ago

This is not necessary for all types