TrinityCore / WowPacketParser

World of Warcraft Packet Parser
GNU General Public License v3.0
410 stars 352 forks source link

Add very rudimentary 3.4.1 parsing support #776

Closed killerwife closed 9 months ago

neifion-00000000 commented 1 year ago

any chance the missing ones can be added into this too?

47720 48340 49345 and current/presumed final is 49822

killerwife commented 1 year ago

Poached from https://github.com/ratkosrb/WowPacketParser/blob/classic/WowPacketParser/Enums/Version/V3_4_1_47014/Opcodes.cs

killerwife commented 1 year ago

@neifion-00000000 filled out 3 missing ones per ymir releases builds.

heyitsbench commented 1 year ago

47966, 48019, 48120, 48340, and 48632 were also PTR builds. There might be more, but those I have packets from.

neifion-00000000 commented 1 year ago

47966, 48019, 48120, 48340, and 48632 were also PTR builds. There might be more, but those I have packets from.

oh yeah, I didn't know there was a differentiation between PTR and live parsing but if so those are needed too (all PTR builds that had sniffing had live builds as well)

ETA: no they don't need added separately @heyitsbench it works like this, just tested, unless you were suggesting the comments themselves need updated

heyitsbench commented 1 year ago

They don't need any special treatment, but the comments for the builds should be adjusted.

Vanheden commented 10 months ago

Any update on this?

Aokromes commented 10 months ago

Conflicting files WowPacketParser/Enums/Version/Opcodes.cs

neifion-00000000 commented 9 months ago

is there some way to sniff the PTR? I mean doesn't matter much at this point it's about to be live but I've been putting a lot of projects off that I need the PTR for accuracy on

killerwife commented 9 months ago

No since no realms are available atm.

neifion-00000000 commented 9 months ago

PTR is up, but ymir is usually updated with PTR only when it matches live versions (and seems to be the case here too, I was asking if anything different was known)

Shauren commented 9 months ago

Merging even if this is almost definitely not 100% correct