Trins-mods / Gravisuit-Classic-Edition

GNU Lesser General Public License v3.0
7 stars 8 forks source link

[Bug] Performance drop when wearing a Jetpack #26

Closed cubicbyte closed 1 year ago

cubicbyte commented 1 year ago

When putting on the Jetpack, the performance (FPS) of the client drops a lot. According to my friend, FPS can drop below 10

image

This applies to almost all jetpacks from yours and the original mod. Moreover, the impact on FPS varies for some.

cubicbyte commented 1 year ago

After looking in the built-in profiler, I found that the cause is in the Jetpack GUI (the one on the top left corner)

image

Trinsdar commented 1 year ago

@CrossVas seems the code you wrote is laggy

CrossVas commented 1 year ago

@cubicbyte could you try this one here (unzip it) gravisuit-2.0.3.zip

cubicbyte commented 1 year ago

@CrossVas In general, everything is fine, but there are still minor decrease from 233 to 210 FPS.

CrossVas commented 1 year ago

@cubicbyte what was the FPS value on previous build? I mean the difference.

cubicbyte commented 1 year ago

@CrossVas You can see on the second screenshot, 126 fps with Jetpack

CrossVas commented 1 year ago

@Trinsdar @cubicbyte the problem was that I've used vanilla MC's gui class for rendering, while the new overlay uses forge's system, which seems to have less impact on overall performance.

Trinsdar commented 1 year ago

So vanilla has a shitty system, why is that not surprising