Trioxidation / Triox

A free file hosting server that focuses on speed, reliability and security.
GNU Affero General Public License v3.0
102 stars 14 forks source link

Update actix-web, tokio and sqlx #37

Closed realaravinth closed 3 years ago

realaravinth commented 3 years ago
codecov-commenter commented 3 years ago

Codecov Report

Merging #37 (1036ac7) into master (d4226e4) will increase coverage by 0.00%. The diff coverage is 27.27%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #37   +/-   ##
=======================================
  Coverage   65.00%   65.00%           
=======================================
  Files          28       27    -1     
  Lines         620      623    +3     
=======================================
+ Hits          403      405    +2     
- Misses        217      218    +1     
Impacted Files Coverage Δ
src/apps/files/list.rs 3.03% <0.00%> (-0.10%) :arrow_down:
src/apps/files/upload.rs 5.55% <ø> (ø)
src/main.rs 4.34% <0.00%> (-0.31%) :arrow_down:
src/tests/helpers.rs 100.00% <ø> (ø)
src/errors.rs 50.00% <37.50%> (-5.18%) :arrow_down:
src/middleware/auth.rs 61.53% <40.00%> (+11.53%) :arrow_up:
src/api/v1/auth.rs 83.11% <100.00%> (+0.22%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d4226e4...1036ac7. Read the comment docs.

realaravinth commented 3 years ago

actix-governor is currently disabled, I have left a TODO in src/api/v1/mod.rs for including it. I don't know how it works. If I understand it correctly, a new middleware instance is created for each service and each service gets its own counter. I hope I am wrong because otherwise, it would be ineffective.

Please send a PR for enabling actix-gernor

realaravinth commented 3 years ago

and anctix-web-4-beta.* is reasonably stable. v3 uses tokio v2 which is painfully old.

AaronErhardt commented 3 years ago

I'll try porting actix-governor to the latest acitx-web beta. Actually there's only one counter (that's stored in the config) despite the API indicating the opposite.