render.js ∆ Swap out headless browser for a more current option.

TripSit / combogen

Project to automatically generate the combo table graphic from our JSON file

22 stars 17 forks source link

render.js ∆ Swap out headless browser for a more current option. #13

Closed ajar closed 2 years ago

ajar commented 2 years ago

Sample PNGs below. Moved from Nightmare to Puppeteer as PhantomJS has been deprecated.

ajar commented 2 years ago

Updated the README.md also. PDFs look good, same as PNG as far as the dimensions go.

ajar commented 2 years ago

@LunaUrsa @LunarUrsan @reality Hey, please see the changes implemented here and merge in when you can. Just bug-fixing, but PDF generation has been added (or re-added?) just as you'd expect it to work. Thank you!

LunaUrsa commented 2 years ago

Tested and this works great, thank you!

LunaUrsa commented 2 years ago

Okay turns out maybe not:

The PDF and HTML files work fine, and half of the PNG files are fine, but certain PNG outputs don't have any text.

EG:

LunaUrsa commented 2 years ago

Only RU, CS, PL and IT are affected

The Italian version (that i recently added) has the title, but nothing else?

This is not happening because some drug names appear on two lines