search

TripSit / combogen

Project to automatically generate the combo table graphic from our JSON file
21 stars 17 forks source link

Fix fonts with diacritics and Cyrillics #18

Open brozkeff opened 1 year ago

brozkeff commented 1 year ago

Fonts used to render the posters do not work for non-ASCII characters.

Czech language has several diacritical marks. Russian etc have Cyrillics. I proposed a PR https://github.com/TripSit/combogen/pull/17 to include latin-ext to include latin-ext and cyrillic script to the Open Sans font used.

However the major issue cannot be fixed so easily since the font on the bottom is probably used from within this include: https://use.typekit.net/ucr7myw.css and that is probably created by someone using Adobe CC software. This font does not contain at all diacritical characters not cyrillics and all chars in Czech or Russian language are typeset with some substitute font and completely different size. This typekit bundle must be refreshed to include all characters or the font must be replaced with something else, at least for non-ASCII languages with any special chars.

LunaUrsa commented 1 year ago

Thanks a ton for this explanation! It sounds like the easier option would be to replace the font?

I'm not a designer, but there are a few people on the discord who may have a thought on this, you're welcome to join us!