TripSit / tripmobile

TripSit mobile app for Android
GNU General Public License v3.0
12 stars 4 forks source link

Enabling local storage, modernizing progress color #44

Closed jasonsyoung closed 6 years ago

jasonsyoung commented 6 years ago

I adjust someone who is more expert at Android double check my changes :)

somehibs commented 6 years ago

Nice, it looks like you found the setting that had a varying default state across OS revisions. Bumping the build targets was good, but we don't want to adjust the minimum SDK until the next version. I'll make the required adjustments on the development branch and get a release out soon.

Thanks for your contribution!

jasonsyoung commented 6 years ago

Of course, I also had some more ideas regarding the persistence of the IRC view. For example, it doesn't save username and resets if android needs to take it's memory. I have some code but its not done yet, would you like me to continue exploring this route or do people usually just rely on third party IRC clients?

Spacebjorn commented 6 years ago

We have a version 2.0, let's say alpha-alpha stage, of the app that practically has its own (working) build in IRC client so that should be good. Maybe I should get it on our Github too.