Pseudocode Review - Githubissues

Tripfantasy / Deduper-tripfantasy

0 stars 0 forks source link

Pseudocode Review #2

Open pranavmuthu opened 2 years ago

pranavmuthu commented 2 years ago

This is fantastic pseudocode! I really like all the background info on concepts, and how you explain the problem and solution in great detail. Using lists instead of dictionaries is a great strategy to optimize the runtime of your code, so I like how you incorporated that.

Suggestions:

Honestly I don't have many other than you don't explicitly mention how you will be outputting your data into a file, but that is a pretty small and easy fix.

Great work!

Tripfantasy commented 2 years ago

Thank you Pranav! Slight overlook on my end. I'll be writing to a new deduped SAM file.