updating agp version to 7.3.0

Triple-T / gradle-play-publisher

GPP is Android's unofficial release automation Gradle Plugin. It can do anything from building, uploading, and then promoting your App Bundle or APK to publishing app listings and other metadata.

MIT License

4.1k stars 339 forks source link

updating agp version to 7.3.0 #1069

Closed tanman2391 closed 1 year ago

tanman2391 commented 1 year ago

Hey there! So you want to contribute to Gradle Play Publisher? Before you file this pull request, follow these steps:

Read the contribution guidelines.
If this has been discussed in an issue, make sure to mention the issue number here. If not, go file an issue about this to make sure it is a desirable change.

https://github.com/Triple-T/gradle-play-publisher/issues/1068

SUPERCILEX commented 1 year ago

Oh, I had a branch that fixed the compilation issue. Will push in a sec.

SUPERCILEX commented 1 year ago

Hmmm, actually I can't find it anymore. You'll just need to add the other two cases and have them do nothing.

tanman2391 commented 1 year ago

Hmmm, actually I can't find it anymore. You'll just need to add the other two cases and have them do nothing.

done. I added simple println calls for the two cases, as I dont like empty flows and didn't want to add a catch all else branch.

SUPERCILEX commented 1 year ago

Looks like you'll need to check the Gradle release notes and see what they changed about the pom. Gradle upgrades are unpleasant, sorry.

github-actions[bot] commented 1 year ago

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

saiday commented 1 year ago

@tanman2391 @SUPERCILEX Thank you for your effort.