search

Triple-T / gradle-play-publisher

GPP is Android's unofficial release automation Gradle Plugin. It can do anything from building, uploading, and then promoting your App Bundle or APK to publishing app listings and other metadata.
MIT License
4.1k stars 339 forks source link

Upgrade AGP to 7.3.0, Gradle to 7.6 #1075

Closed scana closed 1 year ago

scana commented 1 year ago

Fixes https://github.com/Triple-T/gradle-play-publisher/issues/1068

There is one test failing - GenerateResourcesIntegrationTest#'play' file name is not allowed. The thing is that it used to pass due to empty catalogues being passed into GenerateResources task - with the upgrade it's not valid anymore - only actual files are provided.

Parameters before:

/private/var/folders/51/vwgxq3gx39g1g4nk2z7wn9c00000gp/T/junit9788581965445626013/app/src/main/play
/private/var/folders/51/vwgxq3gx39g1g4nk2z7wn9c00000gp/T/junit9788581965445626013/app/src/main/play/default-language.txt
/private/var/folders/51/vwgxq3gx39g1g4nk2z7wn9c00000gp/T/junit9788581965445626013/app/src/main/play/listings
/private/var/folders/51/vwgxq3gx39g1g4nk2z7wn9c00000gp/T/junit9788581965445626013/app/src/main/play/listings/de-DE
/private/var/folders/51/vwgxq3gx39g1g4nk2z7wn9c00000gp/T/junit9788581965445626013/app/src/main/play/listings/de-DE/full-description.txt
/private/var/folders/51/vwgxq3gx39g1g4nk2z7wn9c00000gp/T/junit9788581965445626013/app/src/main/play/listings/en-US
/private/var/folders/51/vwgxq3gx39g1g4nk2z7wn9c00000gp/T/junit9788581965445626013/app/src/main/play/listings/en-US/full-description.txt
/private/var/folders/51/vwgxq3gx39g1g4nk2z7wn9c00000gp/T/junit9788581965445626013/app/src/main/play/listings/en-US/graphics
/private/var/folders/51/vwgxq3gx39g1g4nk2z7wn9c00000gp/T/junit9788581965445626013/app/src/main/play/listings/en-US/graphics/phone-screenshots
/private/var/folders/51/vwgxq3gx39g1g4nk2z7wn9c00000gp/T/junit9788581965445626013/app/src/main/play/listings/en-US/graphics/phone-screenshots/foo.jpg
/private/var/folders/51/vwgxq3gx39g1g4nk2z7wn9c00000gp/T/junit9788581965445626013/app/src/main/play/listings/en-US/graphics/tablet-screenshots
/private/var/folders/51/vwgxq3gx39g1g4nk2z7wn9c00000gp/T/junit9788581965445626013/app/src/main/play/listings/en-US/graphics/tablet-screenshots/baz.jpg
/private/var/folders/51/vwgxq3gx39g1g4nk2z7wn9c00000gp/T/junit9788581965445626013/app/src/main/play/listings/en-US/short-description.txt
/private/var/folders/51/vwgxq3gx39g1g4nk2z7wn9c00000gp/T/junit9788581965445626013/app/src/main/play/listings/en-US/title.txt
/private/var/folders/51/vwgxq3gx39g1g4nk2z7wn9c00000gp/T/junit9788581965445626013/app/src/main/play/listings/fr-FR
/private/var/folders/51/vwgxq3gx39g1g4nk2z7wn9c00000gp/T/junit9788581965445626013/app/src/main/play/listings/fr-FR/full-description.txt
/private/var/folders/51/vwgxq3gx39g1g4nk2z7wn9c00000gp/T/junit9788581965445626013/app/src/main/play/listings/fr-FR/graphics
/private/var/folders/51/vwgxq3gx39g1g4nk2z7wn9c00000gp/T/junit9788581965445626013/app/src/main/play/listings/fr-FR/graphics/phone-screenshots
/private/var/folders/51/vwgxq3gx39g1g4nk2z7wn9c00000gp/T/junit9788581965445626013/app/src/main/play/listings/fr-FR/graphics/phone-screenshots/bar.jpg
/private/var/folders/51/vwgxq3gx39g1g4nk2z7wn9c00000gp/T/junit9788581965445626013/app/src/main/play/listings/fr-FR/short-description.txt
/private/var/folders/51/vwgxq3gx39g1g4nk2z7wn9c00000gp/T/junit9788581965445626013/app/src/main/play/listings/fr-FR/title.txt
/private/var/folders/51/vwgxq3gx39g1g4nk2z7wn9c00000gp/T/junit9788581965445626013/app/src/main/play/products
/private/var/folders/51/vwgxq3gx39g1g4nk2z7wn9c00000gp/T/junit9788581965445626013/app/src/main/play/products/sku.json
/private/var/folders/51/vwgxq3gx39g1g4nk2z7wn9c00000gp/T/junit9788581965445626013/app/src/main/play/release-notes
/private/var/folders/51/vwgxq3gx39g1g4nk2z7wn9c00000gp/T/junit9788581965445626013/app/src/main/play/release-notes/en-US
/private/var/folders/51/vwgxq3gx39g1g4nk2z7wn9c00000gp/T/junit9788581965445626013/app/src/main/play/release-notes/en-US/default.txt
/private/var/folders/51/vwgxq3gx39g1g4nk2z7wn9c00000gp/T/junit9788581965445626013/app/src/main/play/release-notes/fr-FR
/private/var/folders/51/vwgxq3gx39g1g4nk2z7wn9c00000gp/T/junit9788581965445626013/app/src/main/play/release-notes/fr-FR/default.txt
/private/var/folders/51/vwgxq3gx39g1g4nk2z7wn9c00000gp/T/junit9788581965445626013/app/src/illegalPlay/play
/private/var/folders/51/vwgxq3gx39g1g4nk2z7wn9c00000gp/T/junit9788581965445626013/app/src/illegalPlay/play/listings
/private/var/folders/51/vwgxq3gx39g1g4nk2z7wn9c00000gp/T/junit9788581965445626013/app/src/illegalPlay/play/listings/en-US
/private/var/folders/51/vwgxq3gx39g1g4nk2z7wn9c00000gp/T/junit9788581965445626013/app/src/illegalPlay/play/listings/en-US/play

Parameters after:

/private/var/folders/51/vwgxq3gx39g1g4nk2z7wn9c00000gp/T/junit14987822343578711797/app/src/main/play/default-language.txt
/private/var/folders/51/vwgxq3gx39g1g4nk2z7wn9c00000gp/T/junit14987822343578711797/app/src/main/play/listings/de-DE/full-description.txt
/private/var/folders/51/vwgxq3gx39g1g4nk2z7wn9c00000gp/T/junit14987822343578711797/app/src/main/play/listings/en-US/full-description.txt
/private/var/folders/51/vwgxq3gx39g1g4nk2z7wn9c00000gp/T/junit14987822343578711797/app/src/main/play/listings/en-US/graphics/phone-screenshots/foo.jpg
/private/var/folders/51/vwgxq3gx39g1g4nk2z7wn9c00000gp/T/junit14987822343578711797/app/src/main/play/listings/en-US/graphics/tablet-screenshots/baz.jpg
/private/var/folders/51/vwgxq3gx39g1g4nk2z7wn9c00000gp/T/junit14987822343578711797/app/src/main/play/listings/en-US/short-description.txt
/private/var/folders/51/vwgxq3gx39g1g4nk2z7wn9c00000gp/T/junit14987822343578711797/app/src/main/play/listings/en-US/title.txt
/private/var/folders/51/vwgxq3gx39g1g4nk2z7wn9c00000gp/T/junit14987822343578711797/app/src/main/play/listings/fr-FR/full-description.txt
/private/var/folders/51/vwgxq3gx39g1g4nk2z7wn9c00000gp/T/junit14987822343578711797/app/src/main/play/listings/fr-FR/graphics/phone-screenshots/bar.jpg
/private/var/folders/51/vwgxq3gx39g1g4nk2z7wn9c00000gp/T/junit14987822343578711797/app/src/main/play/listings/fr-FR/short-description.txt
/private/var/folders/51/vwgxq3gx39g1g4nk2z7wn9c00000gp/T/junit14987822343578711797/app/src/main/play/listings/fr-FR/title.txt
/private/var/folders/51/vwgxq3gx39g1g4nk2z7wn9c00000gp/T/junit14987822343578711797/app/src/main/play/products/sku.json
/private/var/folders/51/vwgxq3gx39g1g4nk2z7wn9c00000gp/T/junit14987822343578711797/app/src/main/play/release-notes/en-US/default.txt
/private/var/folders/51/vwgxq3gx39g1g4nk2z7wn9c00000gp/T/junit14987822343578711797/app/src/main/play/release-notes/fr-FR/default.txt

@SUPERCILEX I am aware that you do not maintain this project anymore, however could you please tell if the idea behind this test was to verify if no flavor containing the word "play" exists in the project? If so, I'd rather rewrite this check to work differently.