search

Triple-T / gradle-play-publisher

GPP is Android's unofficial release automation Gradle Plugin. It can do anything from building, uploading, and then promoting your App Bundle or APK to publishing app listings and other metadata.
MIT License
4.13k stars 341 forks source link

Copy release notes from previous release also when it's a staged rollout #1105

Closed panpeter closed 1 year ago

panpeter commented 1 year ago

This PR updates the logic related to reusing release notes.

Previously GPP was reusing the latest release notes only in case of a full rollout. Now GPP will reuse the latest release notes also when it's a staged rollout release.

Discussed here: https://github.com/Triple-T/gradle-play-publisher/issues/763#issuecomment-1787267141

✅ Tests pass ✅ Checked with real project ✅ Documentation updated

SUPERCILEX commented 1 year ago

Can you confirm the scenarios you've tested? I'm specifically interested in making sure release notes from past releases are still used if there are none in staging.

panpeter commented 1 year ago

Can you confirm the scenarios you've tested? I'm specifically interested in making sure release notes from past releases are still used if there are none in staging.

I've primarily relied on Track update uses existing release notes when no local ones are available test. For example, if you comment out maybeCopyChangelogFromPreviousRelease the test does not pass. So we should be covered 😊

SUPERCILEX commented 1 year ago

Alright sounds good, thanks! A snapshot build will be published in a bit. If you can make sure everything works with that build, I'd appreciate it.

panpeter commented 1 year ago

Great, thanks!

If you can make sure everything works with that build, I'd appreciate it.

Sure. We'll run a release on Monday. I'll let you know how it goes 👍

panpeter commented 1 year ago

@SUPERCILEX , we've switched to the snapshot version and all works great. The release notes were copied from our previous releases 😊

SUPERCILEX commented 1 year ago

Sweet, fired off a release!