search

Triple-T / gradle-play-publisher

GPP is Android's unofficial release automation Gradle Plugin. It can do anything from building, uploading, and then promoting your App Bundle or APK to publishing app listings and other metadata.
MIT License
4.09k stars 339 forks source link

Workaround for colon track names #1122

Closed sebokopter closed 4 months ago

sebokopter commented 4 months ago

Gradle has an issue that DirectoryProperties.file() does always resolve file names with colon (:) as URI. This breaks when a colon is used as part of a file name.

In this case this is needed for the dedicated PlayStore tracks: tv and wear. They require a corresponding prefix separated by a colon, e.g. "tv:internal". See: developers.google.com/android-publisher/tracks#ff-track-name

Resolving the file paths without DirectoryProperty.file does work around this Gradle issue on Plugin side.

Hey there! So you want to contribute to Gradle Play Publisher? Before you file this pull request, follow these steps:

Closes #1121

SUPERCILEX commented 4 months ago

If you can confirm that everything works in snapshot builds, that'd be great thanks.

sebokopter commented 4 months ago

@SUPERCILEX Thanks for merging the MR.

There's no snapshot build tough, seemingly because the version.txt is missing the snapshot suffix. I've checked the CI: https://github.com/Triple-T/gradle-play-publisher/actions/runs/8207149974/job/22448033711 and the snapshot repo: https://oss.sonatype.org/content/repositories/snapshots/com/github/triplet/gradle/play-publisher/. The latest snapshot is from December 2023.

For what it's worth: I've checked my branch locally via includeBuild and there everything worked fine.

SUPERCILEX commented 4 months ago

Ah, my bad I'll just make a release then.