search

Triple-T / gradle-play-publisher

GPP is Android's unofficial release automation Gradle Plugin. It can do anything from building, uploading, and then promoting your App Bundle or APK to publishing app listings and other metadata.
MIT License
4.13k stars 341 forks source link

Postpone Signing not ready evaluation #806

Closed tprochazka closed 4 years ago

tprochazka commented 4 years ago

Would be possible to move this check Signing not ready for Gradle Play Publisher. Be sure to specify a signingConfig for variant 'defaultCcaDebuggableReleaseNoProguard'. to project.afterEvaluate {} to be sure that setup of this is really done?

I have own plugin which setup custom signing, but I also need to do it in afterEvaluate , because I have custom setup for it, something like 

apply myplugin
apply gradle-play-publisher

myConfig{
  signBy ....
}

So I cannot setup it directly when my plugin is applied. And I not found a way how to react on the moment when myConfig is finished, so I'm waiting to afterEvaluate, but gradle-play-publisher meantime write this error and it is confusing for users.

SUPERCILEX commented 4 years ago

Do you think that warning is even necessary? It's there because it used to be an error, and we've just kind of carried it along. I'd be fine completely removing it.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

tprochazka commented 4 years ago

I agree, that it is probably not necessary. I think that the android build plugin directly will warn that it is missing.

SUPERCILEX commented 4 years ago

Killed. 👍