Create new extension and fill it with config instead of overriding

Triple-T / gradle-play-publisher

GPP is Android's unofficial release automation Gradle Plugin. It can do anything from building, uploading, and then promoting your App Bundle or APK to publishing app listings and other metadata.

MIT License

4.13k stars 341 forks source link

Create new extension and fill it with config instead of overriding #843

Closed WhatDo closed 4 years ago

WhatDo commented 4 years ago

A shitty hack i made to make #842 work.

Problem seems to be that mergeExtensions always modifies the first entry in the list and returns it, but that means the last call in android.onVariants will become the common extension for all variants when any task is actually run.

SUPERCILEX commented 4 years ago

The tests are failing so I can't accept this PR. I'll take a look at the bug at some point though.

WhatDo commented 4 years ago

Yea it was mostly to illustrate what i found the problem to be. I've never developed a gradle plugin before, so i don't really know how to fix it the best way

SUPERCILEX commented 4 years ago

Closing in favor of #844