search

Triple-T / gradle-play-publisher

GPP is Android's unofficial release automation Gradle Plugin. It can do anything from building, uploading, and then promoting your App Bundle or APK to publishing app listings and other metadata.
MIT License
4.12k stars 340 forks source link

Fix documentation for Gradle Script Kotlin #883

Closed ccjernigan closed 3 years ago

ccjernigan commented 3 years ago

The docs here show using a play {} block which I can’t get working with kts+3.0.0 of the plugin.

The error is that val can’t be reassigned, so it looks like the switch to gradle properties doesn’t work nicely.

I looked at the test app and found configure<PlayPublisherExtension> {} syntax.

So it looks like the docs need to be updated to reflect this syntax difference.

SUPERCILEX commented 3 years ago

I'm guessing you're still doing stuff like track = "foo"? It should be track.set("foo").

ccjernigan commented 3 years ago

I made the change for the gradle property API (.set). There seems to be something else going on where the play block wasn't behaving properly but configure<PlayPublisherExtension> {} worked.

This was only when using Gradle Script Kotlin. When my build script is written in Groovy, then the play block worked as expected.

SUPERCILEX commented 3 years ago

Hmmm, that doesn't make much sense since configure and play should be the same. Are you using .set everywhere in the play block? Or maybe you put the play block inside something else that's messing it up? And are you using the plugins { id(...) } block up top?

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.