search

Triple-T / gradle-play-publisher

GPP is Android's unofficial release automation Gradle Plugin. It can do anything from building, uploading, and then promoting your App Bundle or APK to publishing app listings and other metadata.
MIT License
4.12k stars 340 forks source link

Promote staged rollout to 100% requires to use completed status #884

Closed rolgalan closed 3 years ago

rolgalan commented 3 years ago

Hi there!

We've been using this amazing plugin for a while, but today we got problem when trying to promote a staged rollout to 100%. This used to work fine with --release-status inProgress --user-fraction 1.0, but since today Google API returns "User fraction must be lower than one". Which is consistent with their documentation.

It might be interesting to improve the Promoting Artifacts section in the Readme to highlight that --release-status completed --user-fraction 1.0 should be used instead.

Thanks!

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

SUPERCILEX commented 3 years ago

The user fraction can only be used with inProgress status. Marking the release as completed is the same as a full rollout so the user fraction param you're setting is just being ignored.

The plugin could maybe correct the inProgress release to completed if you set the user fraction to 0, but I feel like that might be too much magic.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

SUPERCILEX commented 3 years ago

Oops, still need to decide on this.

SUPERCILEX commented 3 years ago

I'm not a huge fan of magic, so I decided to just add some docs instead of trying to correct the invalid combination.