Closed nhaarman closed 3 years ago
Thanks for the report, I'll take a look.
See #892
Hey folks, so I just checked and https://github.com/Triple-T/gradle-play-publisher/releases/tag/3.1.0-agp4.2-2 is also compatible with AGP 7.0.0-alpha04. I'm going to close this issue, but please file another one if AGP 7 compatibility goes down again.
cc @chrisbanes: in case you aren't subbed to this issue since there are lot of commits referencing it.
Confirmed, thanks!
I still have a problem
Caused by: java.lang.ClassCastException: class com.android.build.api.variant.impl.ApplicationVariantImpl_Decorated cannot be cast to class com.android.build.api.component.analytics.AnalyticsEnabledApplicationVariant (com.android.build.api.variant.impl.ApplicationVariantImpl_Decorated and com.android.build.api.component.analytics.AnalyticsEnabledApplicationVariant are in unnamed module of loader org.gradle.internal.classloader.VisitableURLClassLoader @5e368a38)
at com.github.triplet.gradle.common.validation.ValidationKt.validateDebuggability(Validation.kt:21)
at com.github.triplet.gradle.play.internal.ValidationKt.validateDebuggability(Validation.kt:24)
at com.github.triplet.gradle.play.PlayPublisherPlugin$applyInternal$2.invoke(PlayPublisherPlugin.kt:270)
at com.github.triplet.gradle.play.PlayPublisherPlugin$applyInternal$2.invoke(PlayPublisherPlugin.kt:63)
Here is my configuration
Gradle: 6.8-rc-5 AGP: 7.0.0-alpha04 (classpath 'com.android.tools.build:gradle:7.0.0-alpha04') Triple-T: 3.1.0-agp4.2-2 (classpath "com.github.triplet.gradle:play-publisher:3.1.0-agp4.2-2")
@baole interesting, though I can't repro. I'm curious, is that crashing when you're syncing in the IDE? Or does it also fail on the command line? I'm wondering if the IDE sync respects your data privacy settings and won't upload analytics if you don't click the share data button. (That could explain why it's just an ApplicationVariant
and not an AnalyticsEnabledApplicationVariant
.)
@SUPERCILEX it happens when I'm syncing in the Android Studio and also from command line (ex. ./gradlew clean)
@baole Huh, interesting. I made a fix that I think will work and am going to release it this weekend. Let me know if things are still broken in the upcoming gpp 3.2 release.
Actually I was able to repro, so I'm 99% sure it'll work with GPP 3.2.0-agp4.2-2
.
@SUPERCILEX it works nicely. Thank you very much for the fix.
Describe the bug
I'm using
3.2.0-SNAPSHOT
to overcome the issues described in https://github.com/Triple-T/gradle-play-publisher/issues/864 when using AGP4.2.0-alpha
. When upgrading AGP to7.0.0-alpha01
the following stack trace appears:myproject/app/build.gradle:7
is the following line:Versions