Triple-T / gradle-play-publisher

GPP is Android's unofficial release automation Gradle Plugin. It can do anything from building, uploading, and then promoting your App Bundle or APK to publishing app listings and other metadata.
MIT License
4.13k stars 341 forks source link

Changes cannot be sent for review automatically. Please set the query parameter changesNotSentForReview to true. #956

Closed ihermandev closed 3 years ago

ihermandev commented 3 years ago

Problem description

It seems the library doesn't support this query configuration. During .aab uploading (93% complete) Gradle returns an error on

Task :commitEditForComDot*** FAILED Committing changes

SUPERCILEX commented 3 years ago

Does this happen every time? I can't reproduce.

ihermandev commented 3 years ago

Well, actually it happens when I try to publish a .aab file when an existing app rejected by the play store. There are few ways to workaround the error:

  1. Resolve the rejection and submit again
  2. Upload .aab via web google play console for eg. in Alpha - Closed testing track, publish it and status should be set as "Changes in review"

But the issue is, could we decide from the plugin perspective set changesNotSentForReview to true or false?

Accordingly to https://developers.google.com/android-publisher/api-ref/rest/v3/edits/commit there is a possibility to set changesNotSentForReview as a query parameter

github-actions[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

SUPERCILEX commented 3 years ago

Would you want to be able to control this parameter? I'm think of just trying to send the change for review, and if the commit fails, then retrying but without sending them for review.

ihermandev commented 3 years ago

Actually, there is no necessary to control this parameter so your solution is good

SUPERCILEX commented 3 years ago

Can someone try the snapshot builds? I can't test it properly.

ihermandev commented 3 years ago

I've tested. Everything works as expected. Thank you!

jaynakus commented 3 years ago

So when we can expect this to be released? I have same issue

mx1up commented 3 years ago

I had the same problem and tested out the snapshot release, it works, thanks!

nibblesnbits commented 1 year ago

I'm still seeing this, and it's preventing me from doing releases. It seems the tool itself just needs a small update to explicitly send over the query parameter changesNotSentForReview=true when the "Send changes for review" flag is not set, as it is by default: image

SUPERCILEX commented 1 year ago

This check might not be returning true when it should: https://github.com/Triple-T/gradle-play-publisher/blob/77b069708cfd1bedfce5424af2c4a92cc9439763/play/android-publisher/src/main/kotlin/com/github/triplet/gradle/androidpublisher/Responses.kt#L90-L91

Someone will need to investigate by enabling gradle debug logging and looking at the network request replies.