TripleParity / docks-api

RESTful API Server for Docks
https://tripleparity.github.io/docks-api/stack-api-spec.html
GNU General Public License v3.0
0 stars 0 forks source link

Security #26

Open egeldenhuys opened 6 years ago

egeldenhuys commented 6 years ago

Disclaimer Note: I wear a tinfoil hat and keep my GPG secret keys on a Yubikey.

Would you protect your SSH server with a password? Not if you wear a tinfoil hat. You would only allow public key authentication.

Access to Docks and the ability to bind mount is equivalent to root access to every node in the swarm. Access to Docks should be seen as more valuable as SSH access, therefore it should be protected as such.

Possible Attacks

Possible Solutions

egeldenhuys commented 6 years ago

2FA

Brute Force Attack Mitigation

egeldenhuys commented 6 years ago

In regards to fail2ban, we will at least generate a well defined log to be used by fail2ban.

devosray commented 6 years ago

I have played around with the speakeasy library and it seems very simple and intuitive to use. Implementing 2FA would be a great bonus to the security of the project. Might want to consider making 2FA mandatory for any role that has write permissions.