Triply-Dev / YASGUI.YASQE-deprecated

Deprecated, see https://github.com/TriplyDB/Yasgui for the Yasgui monorepo
MIT License
73 stars 36 forks source link

Separate language strings. Fixes #111. #117

Closed jindrichmynarz closed 6 years ago

jindrichmynarz commented 7 years ago

I've separated the language strings to defaults.js, so that they are exposed as yasqe.options.language and can be thus overwritten by different locale in the YASQE constructor. I've also fixed a couple of typos, such as "Fetchting autocompletions" in autocompletes.utils.js.

This is just a proposal of how localization can be introduced in YASQE. Please advise if there is another preferred way to do so.

LaurensRietveld commented 7 years ago

I got the feeling this might be a bigger issue than expected if done right.

This isnt on my priority list atm as there are a few other YASGUI issues I need to take a stab at. But, if you'd like to take this up, that'd be much appreciated.

LaurensRietveld commented 6 years ago

Closing due to inactivity. Still open to the idea though, but just not at the top of the todo list atm