search

Triply-Dev / YASGUI.YASR-deprecated

Deprecated, see https://github.com/TriplyDB/Yasgui for the Yasgui monorepo
MIT License
26 stars 22 forks source link

in dist/yasr.js relative-require of lib/DataTables/media/js/jquery.dataTables.js will not resolve #11

Closed esjewett closed 10 years ago

esjewett commented 10 years ago

Just upgraded to the latest version of YASR. Thanks for doing the bundle thing here as well!

At the moment we'll need to use the yasr.bundled.min.js as yasr.min.js has a relative require of "lib/DataTables/media/js/jquery.dataTables.js" included in it. Should this either be shimmed or included in the bundle?

LaurensRietveld commented 10 years ago

Shimming should not be required, as this plugin attaches itself to the jquery instance. I've added an example file (see index-deps.html). Let me know if you still experience issues

gr Laurens

esjewett commented 10 years ago

Ah, right. So if we just include the dataTables plugin prior to loading YASR, it won't try to do the relative require? Makes sense. I will give that a shot. Thanks.

LaurensRietveld commented 10 years ago

Jup, it feels a bit fragile though (but it works ;))

On Mon, Oct 27, 2014 at 10:52 PM, Ethan Jewett notifications@github.com wrote:

Ah, right. So if we just include the dataTables plugin prior to loading YASR, it won't try to do the relative require? Makes sense. I will give that a shot. Thanks.

— Reply to this email directly or view it on GitHub https://github.com/YASGUI/YASR/issues/11#issuecomment-60676033.