search

TrippyLighting / EthernetBonjour

Bonjour Library for Arduino & Teensyduino
53 stars 46 forks source link

Move to arduino ide 1.6.4 #3

Closed lathoub closed 9 years ago

lathoub commented 9 years ago

This is an implementation of issue https://github.com/TrippyLighting/EthernetBonjour/issues/2

The only modification to EthernetUDP.h is to declare _sock as protected, not private. All other projects that use EthernetUDP will continue to work (not the case with the friend class)

This pull-request does make direct calls to W5100 in EthernetBonjour.cpp (otherwise placed in EthernetUDP.cpp as per suggested fix in http://forum.arduino.cc/index.php?topic=234340.0)

This implementation has been tested on Mega Pro with Ethernet Shield (not Teensy).

tommag commented 9 years ago

Thanks for sharing your changes ! I just ran into the same problem and had to declare EthernetUdp::_remaining as protected as well.

Cheers, Tom

lathoub commented 9 years ago

I learned from the Arduino team today, that beginMultiast will be part of EthernetUdp.cpp in the upcoming 1.6.6 release. So no need to expose _sock and _remaining as protected any more.

TrippyLighting commented 9 years ago

Thanks for the heads up! This is a relieve and I've been waiting for this for a very long time ;-) I'll update the library when 1.6.6 is released.

On Aug 17, 2015, at 10:45 AM, lathoub notifications@github.com wrote:

I learned from the Arduino team today, that beginMultiast will be part of EthernetUdp.cpp in the upcoming 1.6.6 release. So no need to expose _sock and _remaining as protected any more.

— Reply to this email directly or view it on GitHub.

lathoub commented 9 years ago

Super!

Would you also consider adding support for the "Arduino IDE 1.5: Library specification" https://github.com/arduino/Arduino/wiki/Arduino-IDE-1.5:-Library-specification and post a link as an "issue" on Arduino github so it can be taken up in the Library Manager?

lathoub commented 8 years ago

1.6.6 is released! :-)