Trisha-tech / OnlineBookSales

This project named Online Book Sales - Backend deals with developing an e-commerce website for Online Book Sale. It provides the user with a catalog of different books available for purchase in the store. In order to facilitate online purchase, a shopping cart is provided to the user.
https://book4u-j5au.onrender.com/
MIT License
139 stars 239 forks source link

Added book info page #597

Closed Sourabh782 closed 3 weeks ago

Sourabh782 commented 1 month ago

Description

A clear and concise description of what the PR does.

Related Issues

Link any related issues using the format Fixes #issue_number. This helps to automatically close related issues when the PR is merged.

Changes

List the detailed changes made in this PR.

Testing Instructions

Detailed instructions on how to test the changes. Include any setup needed and specific test cases.

  1. Pull this branch.
  2. Run npm install to install dependencies.
  3. Run npm test to execute the test suite.
  4. Verify that ...

Screenshots (if applicable)

https://github.com/user-attachments/assets/eacc3e52-a95d-4479-a60a-b0b1927efb53

Additional Context

Any additional context or information that reviewers should be aware of.

Checklist

Make sure to check off all the items before submitting. Mark with [x] if done.

github-actions[bot] commented 1 month ago

Thank you for submitting your pull request! πŸ™Œ We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Suman373 commented 1 month ago

@Sourabh782 Hey ! Nice work ! πŸ‘ I think the book image can be made wider to improve the ratio as it looks thinner when compared to the details part.

Sourabh782 commented 1 month ago

@Sourabh782 Hey ! Nice work ! πŸ‘ I think the book image can be made wider to improve the ratio as it looks thinner when compared to the details part.

Sure I tried it, but size was not increasing, still I'll look into it

Suman373 commented 1 month ago

@Sourabh782 Hey ! Nice work ! πŸ‘ I think the book image can be made wider to improve the ratio as it looks thinner when compared to the details part.

Sure I tried it, but size was not increasing, still I'll look into it

You have given a max-width to the parent and have fixed the width of both image and details part. Try to adjust both image and details width.

Sourabh782 commented 4 weeks ago

@Suman373 i have fixed that issue also fixed responsiveness issue : Screenshot 2024-10-23 204506 Screenshot 2024-10-23 204455

Suman373 commented 4 weeks ago

@Sourabh782 Great work ! πŸ™Œ I hope all the other images are looking like this.
@Trisha-tech verify and merge this.

Sourabh782 commented 4 weeks ago

@Sourabh782 Great work ! πŸ™Œ I hope all the other images are looking like this. @Trisha-tech verify and merge this.

Yes the images src are added at image so all are working, I can share video of it

Suman373 commented 4 weeks ago

@Sourabh782 Great work ! πŸ™Œ I hope all the other images are looking like this. @Trisha-tech verify and merge this.

Yes the images src are added at image so all are working, I can share video of it

Not necessary !

Sourabh782 commented 3 weeks ago

@Trisha-tech can you check this pr?

Trisha-tech commented 3 weeks ago

@Trisha-tech can you check this pr?

Kindly look into this once, details of the book are not showing. @Sourabh782

Sourabh782 commented 3 weeks ago

@Trisha-tech can you check this pr?

Kindly look into this once, details of the book are not showing. @Sourabh782

Can you share ss?