Closed Sourabh782 closed 3 weeks ago
Thank you for submitting your pull request! π We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! π
@Sourabh782 Hey ! Nice work ! π I think the book image can be made wider to improve the ratio as it looks thinner when compared to the details part.
@Sourabh782 Hey ! Nice work ! π I think the book image can be made wider to improve the ratio as it looks thinner when compared to the details part.
Sure I tried it, but size was not increasing, still I'll look into it
@Sourabh782 Hey ! Nice work ! π I think the book image can be made wider to improve the ratio as it looks thinner when compared to the details part.
Sure I tried it, but size was not increasing, still I'll look into it
You have given a max-width to the parent and have fixed the width of both image and details part. Try to adjust both image and details width.
@Suman373 i have fixed that issue also fixed responsiveness issue :
@Sourabh782 Great work ! π I hope all the other images are looking like this.
@Trisha-tech verify and merge this.
@Sourabh782 Great work ! π I hope all the other images are looking like this. @Trisha-tech verify and merge this.
Yes the images src are added at image so all are working, I can share video of it
@Sourabh782 Great work ! π I hope all the other images are looking like this. @Trisha-tech verify and merge this.
Yes the images src are added at image so all are working, I can share video of it
Not necessary !
@Trisha-tech can you check this pr?
@Trisha-tech can you check this pr?
Kindly look into this once, details of the book are not showing. @Sourabh782
@Trisha-tech can you check this pr?
Kindly look into this once, details of the book are not showing. @Sourabh782
Can you share ss?
Description
A clear and concise description of what the PR does.
Related Issues
Link any related issues using the format
Fixes #issue_number
. This helps to automatically close related issues when the PR is merged.Changes
List the detailed changes made in this PR.
Testing Instructions
Detailed instructions on how to test the changes. Include any setup needed and specific test cases.
npm install
to install dependencies.npm test
to execute the test suite.Screenshots (if applicable)
https://github.com/user-attachments/assets/eacc3e52-a95d-4479-a60a-b0b1927efb53
Additional Context
Any additional context or information that reviewers should be aware of.
Checklist
Make sure to check off all the items before submitting. Mark with [x] if done.