Initial draft for M1 support + type hinting

TristanBilot / phishGNN

Phishing detection using GNNs

MIT License

12 stars 7 forks source link

Initial draft for M1 support + type hinting #2

Closed helpsystems-mushkevych closed 1 year ago

helpsystems-mushkevych commented 2 years ago

Thank you for your work on the PhishGNN project. I have worked on the codebase in an attempt to make it compatiblew with Apple M1 hardware. Unfortunately it does not work yet, but the collateral changes - such as type hinting or cleanup might be of use to you. Main functional changes are centered around:

pytorch for M1 does not support float64, so I needed to explicitly change it to torch.float32

TristanBilot commented 1 year ago

Hi @helpsystems-mushkevych and thank you for having taking the time to do this PR! Sorry for the (very) late answer, I just merged your PR with few updates. I didn't achieve to fix the M1 GPU issue as well, so I let the device as cpu for the moment, as well as you did. I hope we'll figure out how to leverage the GPU power of M1 in future projects, so let me know if you gain more knowledge about that. Cheers