search

TristanBilot / phishGNN

Phishing detection using GNNs
MIT License
10 stars 7 forks source link

Update main.rs to handle mismatched collection domain entries #6

Closed BlockMageSec closed 1 year ago

BlockMageSec commented 1 year ago

Relevant issue was opened here: https://github.com/TristanBilot/phishGNN/issues/5#issue-1617454511

I was able to get this working, succeeding in outputting ~15,000 entries to CSV, though I intend to batch quite a bit more before I begin training with it, and if need be, I will further update, should I run into any subsequent issues.

I do believe the issue I raised is fixed with this PR. As I had mentioned, I am not very skilled with Rust, so please review and check my work 🙂

71 commented 1 year ago

Hi, and thanks for the PR!

Ideally we'd treat the source of the problem (mismatch of trailing slash) rather than improve error handling around it, however the problem still exists (despite having tried to avoid this kind of scenario), so I'm tempted to accept this PR. I also noticed an error I made while reviewing it, so this is good. 😅 If you don't mind, I'll add a few comments w.r.t. the Rust code (otherwise I'll just apply these changes myself).

BlockMageSec commented 1 year ago

Adjustments made per request 🙂 let me know if this is satisfactory @71

If not, I don't mind making further adjustments.

71 commented 1 year ago

Perfect, thanks!