search

TristanH / bookcision

129 stars 24 forks source link

Downloading limit #1

Closed davidgaldon closed 6 years ago

davidgaldon commented 6 years ago

Hi, I love this tool, really useful. But does it have any kind of limit? It seems it's not downloading all the highlights. I have 301 highlights but it's downloading only the first 84. The same happens when I try to download using different formats (text, json and xml). Thanks!

TristanH commented 6 years ago

Hey David, thanks for writing in and apologies about the slow response. When you go to https://read.amazon.com/notebook , click on the book, and scroll down, are all 301 of the highlights for the book showing? Or only the first 84?

Thanks!

themaanas commented 6 years ago

I have this same problem. All of the highlights are showing but only a part of them are being downloaded.

TristanH commented 6 years ago

Thanks @themaanas -- I think I've been able to recreate this now! Will keep you posted with updates as I explore fixing it.

This may help me debug: do you know when this issue started? Or has it always been broken as far as you know?

Thanks!

davidgaldon commented 6 years ago

Thanks so much for your help, I really think this is a great tool.

I started using it recently, so I can't tell if it was fully working before.

Let me know if you want me to do some testing on my end.

Thanks again, David

On Sat, Sep 8, 2018 at 10:33 AM TristanH notifications@github.com wrote:

Thanks @themaanas https://github.com/themaanas -- I think I've been able to recreate this now! Will keep you posted with updates as I explore fixing it.

This may help me debug: do you know when this issue started? Or has it always been broken as far as you know?

Thanks!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/TristanH/bookcision/issues/1#issuecomment-419651550, or mute the thread https://github.com/notifications/unsubscribe-auth/AQKOkX1-Pmpb-rAF7o3Lg-27jPKQkOrKks5uY-MxgaJpZM4V5P9X .

-- David Galdon 512-221-8064 davidgaldonh@gmail.com https://www.linkedin.com/in/davidgaldon

TristanH commented 6 years ago

Hey @davidgaldon and @themaanas -- this should be fixed now in the latest version. You guys should simply be able to try again and have it work :)

Going to close this issue now, but please do let me know if there are any other issues!

fcherman commented 4 years ago

I'm having the same problem. I've highlighted text all the way up to location 2051 (the book is not long – just 176 pages), but the bookmarklet stops at location 1610 (page 135). Some of my highlighted passages are quite long, if that makes a difference. By contrast, Amazon's notebook feature, not only fails to display any comments after page 135, it also truncates many of the passages it does display (see screenshot).

Amazon Notebook image

I just noticed a few more errors. The screenshot below shows the highlights as rendered in Kindle Cloud Reader (left) and as rendered in Bookcision (right). Note that special characters, such as en dashes and curly apostrophes, are misrendered. In addition, one paragraph is truncated abruptly.

Kindle Cloud Reader (left); Bookcision (right) image