Implement new signal based events

TritonDataCenter / containerpilot

A service for autodiscovery and configuration of applications running in containers

Mozilla Public License 2.0

1.13k stars 135 forks source link

Implement new signal based events #520

Closed jwreagor closed 6 years ago

jwreagor commented 7 years ago

Ref: #513

This PR implements the process outlined in the tracking issue. I've also included the ability for running jobs to create an environment variable including their PID (CONTAINERPILOT_<name>_PID) as well as both the supervisor and normal worker process signal handlers. So far, the functionality is working out great and you can fire jobs based on a container receiving a specific signal (or CP process itself). Obviously this is more of a scheduler based feature for CP and not something useful for the Triton audience.

I'm still testing this and looking to make sure nothing that I've changed is going to cause havoc to the supervisor process.

jwreagor commented 7 years ago

I'm taking my time testing this since I'll be introducing behavior into the supervisor process. I already have plans to change my original implementation under this WIP PR. I've found some optimizations but also weird behavior (dup signals passing).

jwreagor commented 7 years ago

Latest commits include fixes from master as well as simplifying the supervisor logic. I'll perform final testing tomorrow.

jwreagor commented 7 years ago

Alright, I think this is baked enough. Couple things to note...

I reverted the control endpoint for triggering signal events over HTTP. A part of me is wondering if this would have been handy either way, as one could trigger a custom event within CP running on Triton.
I've added some documentation.

I'll get CR of this next week.

jwreagor commented 7 years ago

/cc @stack72 for CR, I'll test on my own one last time and get this out the door this week.

jwreagor commented 6 years ago

Going to test this one last time and get this merged today.

jwreagor commented 6 years ago

Going to close this PR, do the squash manually, and open a second for the merge.