search

TritonDataCenter / illumos-extra

Extra non-ON software required for Illumos
Other
39 stars 47 forks source link

OS-8589 openssl1x update for gcc 14 #126

Closed tsoome closed 2 days ago

tsoome commented 4 days ago

Fix declaration (line 9). Cast over uintptr_t so the structure size check would not be used. Add check for array index. Signature algorithms start from 1, so idx > 0 is good check.

tsoome commented 3 days ago

Why does this patch name refer to gcc16?

This one remains one of the big mysteries about the universe:D Of course, I must have typed 6 instead of 4:)

tsoome commented 3 days ago

Please make sure these tests are run before anyone IAs; I can help if need be.

On before-this-patch and after-this-patch with stock gcc10 builds check diffs between

  • dis .../ssl/s3_cbc.o > /tmp/{before,after}
  • dis .../crypto/bio/b_sock.c

The t1_lib.c will have altered code, but it seems sensible enough via inspection.

no differences: [tsoome@smartos-dev-21 /tmp]$ diff -u b_sock.before b_sock.after [tsoome@smartos-dev-21 /tmp]$ diff -u s3_cbc.before s3_cbc.after [tsoome@smartos-dev-21 /tmp]$

danmcd commented 2 days ago

Please do not push until after tonight's release branch.