TritonDataCenter / illumos-joyent

Community developed and maintained version of the OS/Net consolidation
http://www.illumos.org/projects/illumos-gate
265 stars 111 forks source link

OS-8459 (C program version) #447

Closed danmcd closed 1 year ago

danmcd commented 1 year ago

It needs some more work like moving/renaming pkgsrc-wrapper but the C version works well, and appears to work with login shells too if the mapping function takes -$SHELL into account.

danmcd commented 1 year ago

Okay, currently I think (assuming the full smartos-live build works) we need to do is possibly rename pkgsrc-wrapper, but I leave that to the reviewers for now.

bahamat commented 1 year ago

Another test to try is to have a shell script for each interpreter that just does ptree $$.

danmcd commented 1 year ago

Another test to try is to have a shell script for each interpreter that just does ptree $$.

Will be placing results on jira ticket.

danmcd commented 1 year ago

So I'd like:

danmcd commented 1 year ago

Remaining KEBE comments could use some answers, also what about the man page, which I haven't renamed to "altexec" yet, because I'm wondering if it NEEDS a man page (or not)?

bahamat commented 1 year ago

About the man page, I was thinking it would be a way to make it discoverable when they were symlinks, but with them being hardlinks now, I don't think it will be very easily found so I think there's less utility in having it. And it's not going to work out with the "magic" man page redirection (GZ default is to have /usr first and /opt/tools last).

I'm not opposed to removing the man page entirely.

danmcd commented 1 year ago

So I've lost the man page and answered the "needs diagnostics" KEBE comments. The only KEBE comments left are about the messages we do print; sorry if I missed earlier comments here or on chat about that.

danmcd commented 1 year ago

Note to self: include OS-8462 and OS-8461 in the commit message.

danmcd commented 1 year ago

Three KEBE comments left, all around message wording.

danmcd commented 1 year ago

Still needs L10N wrapping.