search

TritonDataCenter / illumos-joyent

Community developed and maintained version of the OS/Net consolidation
http://www.illumos.org/projects/illumos-gate
265 stars 111 forks source link

12455 want SO_REUSEPORT support #468

Closed cneira closed 2 months ago

cneira commented 2 months ago

Hi,

Some applications require SO_REUSEPORT support as this in some cases increases performance. I checked at the work done here https://code.illumos.org/c/illumos-gate/+/464 and synced up the code to current illumos-joyent. I run the tests created for this feature and results are OK, I'm also running and unbound zone using reuseport options and so far so good.

Let me know which additional work is required to move this forward.

authored-by: araragihokuto@outlook.com Co-authored-by: cneirabustos@gmail.com

Bests

jclulow commented 2 months ago

I think it would be best to take this into illumos-gate rather than just one downstream like illumos-joyent.

danmcd commented 2 months ago

Agreed @jclulow , especially for this one. Best thing you can do IMHO, @cneira , is test the ever-living-daylights out of this wad, and report your findings!

cneira commented 2 months ago

@jclulow @danmcd ok, I'll submit this patch to illumos-gate. Bests

danmcd commented 2 months ago

@cneira You can test this on SmartOS, but the ultimate fix should land in -gate first. (I haven't seen if this affects code paths that are specific to SmartOS or not.)

cneira commented 2 months ago

@danmcd @jclulow I just uploaded changes for this for review https://code.illumos.org/c/illumos-gate/+/3457