TritonDataCenter / java-http-signature

Library for performing RSA signed HTTP requests in Java
Mozilla Public License 2.0
17 stars 13 forks source link

Adds signature caching to the apache-http-client module #26

Closed dekobon closed 7 years ago

twopairs commented 7 years ago

With signature-cache branch, signature caching could be come true, but in some case, user can create inefficient code that is not intended on SDK, for example /=================================/ for(int i=0; i<N; i++) { UploadWorker w = new UploadWorker(new MantaClient(...), ...); w.start(); /=================================/

When there are multi-threads, if user does not re-use the MantaClient instance, Sharing across threads are not possible, so it seems that guideline, documentation and example code is necessary.

dekobon commented 7 years ago

I will improve the documentation within the java-manta project once this change is committed and integrated.