search

TritonDataCenter / java-manta

Java Manta Client SDK
Mozilla Public License 2.0
16 stars 26 forks source link

Standardize .equals() across SDK, Fixing Issue#477 #498

Closed indianwhocodes closed 5 years ago

dekobon commented 5 years ago

My apologies if the description of the bug was unclear. What I intended with this issue was to do the same boilerplate code in every .equals() and .hashCode() method. Right now we have various different implementations.

indianwhocodes commented 5 years ago

These are the follow-up changes that have been made after the discussion that convened in #477. These changes have been verified in staging.

indianwhocodes commented 5 years ago

Noted.

indianwhocodes commented 5 years ago

I want us to not do a squash merge on the merge for this change.

Can you take all of the changes in this PR and form it into the following commits:

  • Copyright header commit
  • Equals changes commit
  • String literal refactor commit

I'm good with the changes, but with such refactorings it will be good that the changes are clearer. 👍

All refactoring of commits and pre-requisites that were needed to make #498 eligible for a merge have been performed.

indianwhocodes commented 5 years ago

This Pull-Request will be rebased and merged into the release-branch as per the discussion that was convened in #498 to preserve the commit logs.