TritonDataCenter / java-manta

Java Manta Client SDK
Mozilla Public License 2.0
16 stars 26 forks source link

test suite could fail early if Manta authentication set up is wrong #556

Open jlevon opened 4 years ago

jlevon commented 4 years ago

As can be seen in #515 the failure mode when a dev has made an error with setting up MANTA_KEY_ID and/or MANTA_KEY_PATH, or not having added the key to the Manta installation itself, is really not clear. That is, you get:

Cannot instantiate class com.joyent.manta.http.TCPSocketConnectionTimeoutIT
    at org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:673)
    at org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:535)
    at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:280)
    at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:245)
    at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(Abst

some good way down the results.

It would be much simpler if we could check the authentication specifically before running any of the integration tests. For example, if we ran 'java-manta-cli put-file' or something, then if we get an authorized response back, we could immediately fail the tests with a message like:

 <cli invocation> failed with <error from manta>: is the Manta key configuration correct?