search

TritonDataCenter / manta-thoth

Thoth is a Manta-based system for core and crash dump management
16 stars 7 forks source link

thoth debug supports passing binary into MDB #142

Open geek opened 7 years ago

jclulow commented 7 years ago

Would it be better to provide a way to upload a binary for a particular thoth dump, and to have thoth debug then use it each time automatically?

geek commented 7 years ago

@jclulow we could do that. I do think your suggestion will be easier to use, but I prefer to make it a separate step and the path explicit. Would you thoth upload node and then associate it with an object?

jclulow commented 7 years ago

Presumably this is for situations where the debugging information is not included in the core file itself, so the original executable is also needed to provide mdb with a complete picture?

I think I would probably extend thoth upload to optionally accept a binary as well as a core file, and to track it as a first class artefact alongside the core itself.

geek commented 7 years ago

@jclulow that makes sense. I will let you make the call on if we should do that. It may complicate the code a bit to detect which of the files is the core, as well as checking if the binary is already uploaded (for potential reuse).

geek commented 7 years ago

@jclulow this is now updated to upload the program that created the core and associate it with the core for loading into MDB.