search

TritonDataCenter / node-artedi

a library for measuring fish
2 stars 4 forks source link

MANTA-4959 Don't use Math.log10() because it's not available in old versions of node #23

Closed khalfella closed 4 years ago

joshwilsdon commented 4 years ago

Out of curiosity, what's using node 0.10 that can't be updated?

khalfella commented 4 years ago

Out of curiosity, what's using node 0.10 that can't be updated?

Muskie for mantav1 uses node v0.10. It can definitely be updated to a newer version but node. However, I am not sure if it is worth the efforts to update muskie to a newer version of node.

joshwilsdon commented 4 years ago

Muskie for mantav1 uses node v0.10.

What are we adding to muskie for mantav1 that requires the new artedi?

khalfella commented 4 years ago

We are updating muskie to take advantage of the new histogram implementation. See MANTA-4388.