search

TritonDataCenter / node-artedi

a library for measuring fish
2 stars 4 forks source link

Implement set() for Gauge collectors #5

Closed KodyKantor closed 7 years ago

KodyKantor commented 7 years ago

We should implement the AbsoluteGauge collector.

The docs for that are already partially written here.

KodyKantor commented 7 years ago

CR: https://cr.joyent.us/#/c/2606/

KodyKantor commented 7 years ago

After a round of review, we've decided that the AbsoluteGauge class should be folded into the existing Gauge class. We felt that having a second gauge type was confusing and made the API larger than it needed to be. I'll rename this issue from 'Implement AbsoluteGauge' to 'Implement set() for Gauge collectors.'

KodyKantor commented 7 years ago

Added in b9d8c0e