artedi shouldn't attach timestamps to prometheus metrics

TritonDataCenter / node-artedi

a library for measuring fish

2 stars 4 forks source link

artedi shouldn't attach timestamps to prometheus metrics #7

Closed KodyKantor closed 7 years ago

KodyKantor commented 7 years ago

Prometheus metric clients aren't supposed to attach timestamps to metrics. The prometheus server will attach timestamps when metrics are scraped.

It may still be useful to have timestamps tracked in memory for debugging, or other serialization formats. For that reason we can keep them in the code, just not serialize them when the user requests prometheus serialization.

KodyKantor commented 7 years ago

CR: https://cr.joyent.us/#/c/2606/

KodyKantor commented 7 years ago

Added in b9d8c0e