search

TritonDataCenter / node-asn1

Contains parsers and serializers for ASN.1 (currently BER only)
MIT License
64 stars 35 forks source link

fix typo #13

Open peecky opened 10 years ago

peecky commented 10 years ago

I found a meaningless if condition which always become false, because not operator(!) is evaluated before the instanceof operator.

StefH commented 8 years ago

This is actually a compile error, not a type.

Also fixed in https://github.com/mcavage/node-asn1/pull/21

Voles commented 7 years ago

@peecky were you able to resolve this based on @StefH's comment?

StefH commented 7 years ago

@peecky : Any update?

stephenwvickers commented 7 years ago

I have seen there is little progress on this project over the past few years. My project, the net-snmp project, depends on this project, so I have cloned it and migrated (i.e. copied) all the outstanding issues and pull requests.

I will be releasing a new version of my version of this project under the asn1-ber namespace on npmjs.org by the end of the week which should address this particular item (I've already pushed the current code to this namespace to reserve it).

I am now tracking all changes under my own copy at asn1-ber. Note that this is not a "fork" but a clone and fresh commit to a new repository. I have of course retained all copyrights and attributed back the original author.

There are quite a few projects dependant on this project, and I want to make sure there is momentum on the issues and feature requests reported.

stephenwvickers commented 7 years ago

This issue has been addressed in my version of this project which has now been published to npm:

https://www.npmjs.com/package/asn1-ber