TRITON-1943 add Jenkinsfiles to Triton repositories

TritonDataCenter / node-assert-plus

Extra assertions on top of node's assert module

MIT License

122 stars 25 forks source link

TRITON-1943 add Jenkinsfiles to Triton repositories #37

Closed cburroughs closed 4 years ago

cburroughs commented 4 years ago

I think the failures can at least partially be accounted for by #38 Will need to land that first to be sure.

cburroughs commented 4 years ago

My rebase cleared the review state. Not sure if there is a way to not do that. As expected, after #38 things are green.

trentm commented 4 years ago

My rebase cleared the review state. Not sure if there is a way to not do that.

Screenshot 2019-10-21 09 06 34

Chris, I believe that is due to this setting that we have on all our "master" branch protection. I'm not sure what it means to not have that checked. In general at least, if there is a new commit one should have to re-review the PR.