TritonDataCenter / node-bunyan-syslog

Syslog Stream for node-bunyan
MIT License
67 stars 68 forks source link

Version 0.3.1 fails to build on Linux with node 0.10 #33

Open thaumant opened 8 years ago

thaumant commented 8 years ago
$ uname -srp
Linux 2.6.32-042stab104.1 x86_64
$ node -v
v0.10.36
$ npm i bunyan-syslog@0.3.1
npm WARN package.json test@0.0.0 No description
npm WARN package.json test@0.0.0 No repository field.
npm WARN package.json test@0.0.0 No README data
npm http GET https://registry.npmjs.org/bunyan-syslog/0.3.1
npm http 200 https://registry.npmjs.org/bunyan-syslog/0.3.1
npm http GET https://registry.npmjs.org/bunyan-syslog/-/bunyan-syslog-0.3.1.tgz
npm http 200 https://registry.npmjs.org/bunyan-syslog/-/bunyan-syslog-0.3.1.tgz

> bunyan-syslog@0.3.1 install /home/thaumant/test/node_modules/bunyan-syslog
> node-gyp rebuild

make: Entering directory `/home/thaumant/test/node_modules/bunyan-syslog/build'
  CXX(target) Release/obj.target/syslog/src/syslog.o
In file included from ../src/syslog.cc:7:0:
../../nan/nan.h:328:47: error: 'REPLACE_INVALID_UTF8' is not a member of 'v8::String'
   static const unsigned kReplaceInvalidUtf8 = v8::String::REPLACE_INVALID_UTF8;
                                               ^
make: *** [Release/obj.target/syslog/src/syslog.o] Error 1
make: Leaving directory `/home/thaumant/test/node_modules/bunyan-syslog/build'
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/lib/node_modules/node-gyp/lib/build.js:267:23)
gyp ERR! stack     at ChildProcess.emit (events.js:98:17)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:820:12)
gyp ERR! System Linux 2.6.32-042stab104.1
gyp ERR! command "node" "/usr/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /home/thaumant/test/node_modules/bunyan-syslog
gyp ERR! node -v v0.10.36
gyp ERR! node-gyp -v v0.10.6
gyp ERR! not ok
npm ERR! weird error 1
npm ERR! not ok code 0

Version 0.3.0 builds successfully.

pfmooney commented 8 years ago

It seems to be installing fine for me:

[pmooney@testhost test]$ node --version
v0.10.36
[pmooney@testhost test]$ npm --version
1.4.28
[pmooney@testhost test]$ npm i bunyan-syslog@0.3.1
/
> bunyan-syslog@0.3.1 install /home/pmooney/git/test/node_modules/bunyan-syslog
> node-gyp rebuild

make: Entering directory '/home/pmooney/git/test/node_modules/bunyan-syslog/build'
  CXX(target) Release/obj.target/syslog/src/syslog.o
  SOLINK_MODULE(target) Release/obj.target/syslog.node
  SOLINK_MODULE(target) Release/obj.target/syslog.node: Finished
  COPY Release/syslog.node
make: Leaving directory '/home/pmooney/git/test/node_modules/bunyan-syslog/build'
bunyan-syslog@0.3.1 node_modules/bunyan-syslog
├── assert-plus@0.1.5
└── nan@2.1.0

Is the result the same if you purge the node_modules directory and retry the install?

ziir commented 8 years ago

I'm having the same issue on a regular basis on 0.3.0 and 0.3.1, working around it by :

npm install -g npm@latest-2
npm rebuild bunyan-syslog

Thanks for the work :)