Similar to #16, GitLab also allows more characters in the namespace section, for example registry.gitlab.com/user.name/repo-name-a/repo-name-b (based on an actual (private) repo, anonymized).
That currently leads to errors like this: "invalid repository namespace, may only contain [a-z0-9_-] characters: user.name"
Similar to #16, GitLab also allows more characters in the namespace section, for example registry.gitlab.com/user.name/repo-name-a/repo-name-b (based on an actual (private) repo, anonymized).
That currently leads to errors like this: "invalid repository namespace, may only contain [a-z0-9_-] characters: user.name"
To address that, the
VALID_NS
regex would need to be extended, adding\.
to the bracket expression: https://github.com/joyent/node-docker-registry-client/blob/b35b61e92c545d0d58b409ad7b87864265a2337a/lib/common.js#L36I'm not familiar with tests in this repo, so if this change makes sense, I'd appreciate some hints for extending tests. If thats worth the effort.