Closed rankida closed 5 years ago
Fixes #29
Unfortunately we cannot accept this merge request, as it will cause some issues with the Triton software stack, notably:
base64url version 2 and above requires node 6+, but the Triton stack (imgapi and docker parts) that uses this module are currently using node 4.
restify-clients moving across major versions may create some incompatibilities between dependent Triton software
restify-errors moving across major versions may create some incompatibilities between dependent Triton software
@twhiteman How about tough-cookie? https://github.com/joyent/node-docker-registry-client/pull/14
Unfortunately not either (as our node dependencies are very old). Closed #14.
Unfortunately not either (as our node dependencies are very old). Closed #14.
Is this still the case, 3 years later? Oldest supported version of NodeJS is currently 12. So in theory we should be able to update dependencies of this module.
I know I should log this using Gerrit, but I have read the user guide and it is still unclear how I (a non-Joyent engineer) do this.
I guess I will need to keep trying.
Before:
Now: