search

TritonDataCenter / node-http-signature

Reference implementation of Joyent's HTTP Signature Scheme
https://tritondatacenter.com
MIT License
405 stars 118 forks source link

add support for created and expires values #110

Closed blacktemplar closed 4 years ago

blacktemplar commented 4 years ago

Resolves #109.

Adds support for created and expires values in parser and signer.

zetxx commented 4 years ago

+1 is anyone on this ?

jasonbking commented 4 years ago

I'll try to get this reviewed sometime the next several days..

blacktemplar commented 4 years ago

I fixed all make check errors and added some new tests, testing the parsing behavior.

make test runs through except for one test (not ok 10 test/examples.test.js) which I think is unrelated to my pull request and also fails on my machine on the master branch.

But the CI still fails, so I am not sure whats the fault.

PS: would be good to document somewhere that one needs to install the npm package json globally to use make check, at least I didn't find it anywhere and needed some googling.