search

TritonDataCenter / node-http-signature

Reference implementation of Joyent's HTTP Signature Scheme
https://tritondatacenter.com
MIT License
405 stars 118 forks source link

Add Ed25519 signature algorithm using TweetNaCl #38

Closed tdfischer closed 8 years ago

tdfischer commented 9 years ago

Note that Ed25519 keys must be Base64-encoded

arekinath commented 8 years ago

I've been thinking about this one a lot and talking to some of the other Joyent folks, and we really don't want http-signature to have a dependency on a C extension module like this. It makes updates between versions of node too difficult, in particular.

If there was a version of optionalDependencies, which let users specify "flavours" or something like that I'd consider bringing this in as a configurable option for users, but as it is I don't think it's a good idea.

If/when OpenSSL (and thus the built-in crypto module) has support for ED25519, I would definitely like to look at including support -- I really do like the algorithm, in particular the ability to have deterministic signatures (which other forms of ECDSA lack). But we can't accept it right now as it is, sorry.