search

TritonDataCenter / node-http-signature

Reference implementation of Joyent's HTTP Signature Scheme
https://tritondatacenter.com
MIT License
404 stars 118 forks source link

Publish new version to NPM #49

Closed sebdeckers closed 9 years ago

sebdeckers commented 9 years ago

Quite a few changes were made since the 0.10.0 release. Time for a version bump and npm publish?

(I'm interested because of the removed asn1@0.1.11 and ctype@0.5.3 dependencies, which are giving me warnings about their license.)

arekinath commented 9 years ago

I'd like to finish off a few more ideas that I'm asking people to review for me at the moment before we cut a release. They're not too revolutionary, so I don't think it'll take too long.

FYI, there is still an indirect dep on asn1, but it's the latest version which has the license field filled out in its package.json (yay). It has always included the MIT license file in the package, though.

sebdeckers commented 9 years ago

That sounds great, and thanks for the response! :smile:

arekinath commented 9 years ago

Ok, v1.0.0 is now released. https://github.com/joyent/node-http-signature/blob/master/CHANGES.md has the summary of what's new.

sebdeckers commented 9 years ago

Btw seems like http-signature@1.0.0 breaks a test in request@2.65.0 (latest) so that dependency can't simply be bumped. I'm not familiar enough with request nor http-signature to know what the breaking changes are. Is this something you're aware of or should I spend some time debugging?

rmustacc commented 9 years ago

@cbas we already understand the problem, you don't need to spent time digging into it. You can follow #50 for more information.