search

TritonDataCenter / node-macaddr

Library for MAC address parsing and manipulation
3 stars 4 forks source link

node-macaddr#3 Want custom separator and custom formatter #2

Closed cableray closed 3 years ago

cableray commented 3 years ago

In order to output various types easily, allow setting a custom separator, and allow providing a function to specify formatting.

Let me know what else is needed, please :)

cableray commented 3 years ago

I think I'm going to change it so that the formatter doesn't override the padding, and then extract the default formatter to a function to simplify...

cableray commented 3 years ago

I'd like to change the loop to a map, but that may be too much for this pr....

bahamat commented 3 years ago

Still evaluating this, but at the very least it will need a version bump in package.json.

cableray commented 3 years ago

Still evaluating this, but at the very least it will need a version bump in package.json.

So, 0.1.0? It's a non-breaking new feature, so minor bump? Given as it is currently at 0.0.1, I didn't think it had been versioned before... Also, should I commit the auto reformatting of package.json? (Looks like npm re-ordered some packages)

bahamat commented 3 years ago

Yeah, 0.1.0 is fine. There's only 3 commits so far in this repo so far. The first one was just creating the repo from our template, the second was ver 0.0.1, and the third commit was just updating the make check dependency, and no change in the behavior of the library.

And for the structure of package.json, making the diff minimal is easier to read, but other than that I don't have a strong opinion about it.

cableray commented 3 years ago

Oops, changed the spacing in brackets... let me revert that...