TritonDataCenter / node-manta-sync

Rsync style command for Joyent's Manta
31 stars 9 forks source link

fix cases where a missed cb() would result in manta-sync stopping with unfinished work, exiting 0 when there were errors #23

Closed trentm closed 7 years ago

trentm commented 7 years ago

a failing example run: https://gist.github.com/trentm/7ac546372af934cb30859ba6cd87a3dd

a working example run: https://gist.github.com/trentm/960be6afb7f3697d7f5df45d484cfb41 (where "working" means that manta-sync properly exited non-zero when there were auth errors).

The repro case was when doing a large manta-sync (from manta to local) very soon after adding the used SSH key to the account.

bahamas10 commented 7 years ago

good catch, thanks!

bahamas10 commented 7 years ago
$ npm publish
+ manta-sync@0.3.4