In an earlier version of the MPU implementation in muskie, which was deployed as a feature branch image, only two possible states were returned from get-mpu: created and finalizing. This was inconsistent with the original design, which included a third state: done. The mmpu tool was integrated prior to the MPU changes in muskie's master branch, but the node-manta tests were not updated after muskie was changed to reflect the initial design. As a result, the mmpu tests and client tests that commit and abort uploads (then verify as such by doing an mpu-get) will fail with the incorrect state.
This results in errors that look like the following:
✖ commit upload
AssertionError: 'done' == 'finalizing'
at Object.equal (/Users/jordan.hendricks/work/joyent-repos/node-manta/node_modules/nodeunit/lib/types.js:83:39)
at /Users/jordan.hendricks/work/joyent-repos/node-manta/test/client.test.js:794:15
at /Users/jordan.hendricks/work/joyent-repos/node-manta/lib/client.js:3546:17
at parseResponse (/Users/jordan.hendricks/work/joyent-repos/node-manta/node_modules/restify-clients/lib/JsonClient.js:93:9)
at IncomingMessage.done (/Users/jordan.hendricks/work/joyent-repos/node-manta/node_modules/restify-clients/lib/StringClient.js:207:13)
at IncomingMessage.g (events.js:199:16)
at IncomingMessage.emit (events.js:129:20)
at _stream_readable.js:908:16
at process._tickCallback (node.js:355:11)
AssertionError
at Object.equal (/Users/jordan.hendricks/work/joyent-repos/node-manta/node_modules/nodeunit/lib/types.js:83:39)
at /Users/jordan.hendricks/work/joyent-repos/node-manta/test/client.test.js:795:15
at /Users/jordan.hendricks/work/joyent-repos/node-manta/lib/client.js:3546:17
at parseResponse (/Users/jordan.hendricks/work/joyent-repos/node-manta/node_modules/restify-clients/lib/JsonClient.js:93:9)
at IncomingMessage.done (/Users/jordan.hendricks/work/joyent-repos/node-manta/node_modules/restify-clients/lib/StringClient.js:207:13)
at IncomingMessage.g (events.js:199:16)
at IncomingMessage.emit (events.js:129:20)
at _stream_readable.js:908:16
at process._tickCallback (node.js:355:11)
✖ abort upload
AssertionError: 'done' == 'finalizing'
at Object.equal (/Users/jordan.hendricks/work/joyent-repos/node-manta/node_modules/nodeunit/lib/types.js:83:39)
at /Users/jordan.hendricks/work/joyent-repos/node-manta/test/client.test.js:837:19
at /Users/jordan.hendricks/work/joyent-repos/node-manta/lib/client.js:3546:17
at parseResponse (/Users/jordan.hendricks/work/joyent-repos/node-manta/node_modules/restify-clients/lib/JsonClient.js:93:9)
at IncomingMessage.done (/Users/jordan.hendricks/work/joyent-repos/node-manta/node_modules/restify-clients/lib/StringClient.js:207:13)
at IncomingMessage.g (events.js:199:16)
at IncomingMessage.emit (events.js:129:20)
at _stream_readable.js:908:16
at process._tickCallback (node.js:355:11)
AssertionError
at Object.equal (/Users/jordan.hendricks/work/joyent-repos/node-manta/node_modules/nodeunit/lib/types.js:83:39)
at /Users/jordan.hendricks/work/joyent-repos/node-manta/test/client.test.js:838:19
at /Users/jordan.hendricks/work/joyent-repos/node-manta/lib/client.js:3546:17
at parseResponse (/Users/jordan.hendricks/work/joyent-repos/node-manta/node_modules/restify-clients/lib/JsonClient.js:93:9)
at IncomingMessage.done (/Users/jordan.hendricks/work/joyent-repos/node-manta/node_modules/restify-clients/lib/StringClient.js:207:13)
at IncomingMessage.g (events.js:199:16)
at IncomingMessage.emit (events.js:129:20)
at _stream_readable.js:908:16
at process._tickCallback (node.js:355:11)
The tests need to be updated to match what is in muskie's master branch for MPU.
In an earlier version of the MPU implementation in muskie, which was deployed as a feature branch image, only two possible states were returned from
get-mpu
:created
andfinalizing
. This was inconsistent with the original design, which included a third state:done
. The mmpu tool was integrated prior to the MPU changes in muskie's master branch, but the node-manta tests were not updated after muskie was changed to reflect the initial design. As a result, the mmpu tests and client tests that commit and abort uploads (then verify as such by doing anmpu-get
) will fail with the incorrect state.This results in errors that look like the following:
The tests need to be updated to match what is in muskie's master branch for MPU.