search

TritonDataCenter / node-manta

Node.js SDK for Manta
75 stars 54 forks source link

ask server for fully qualified upload path #325

Closed jclulow closed 7 years ago

jclulow commented 7 years ago

The client library presently assumes too much about the structure of the uploads directory in Manta, as used for multipart uploads. Manta will respond with a HTTP redirect to the fully qualified upload path if a request is made to /ACCOUNT/uploads/UPLOAD_ID. We should make this request to transform a multipart upload ID into the fully qualified path.

jclulow commented 7 years ago

Gerrit CR 2577 (joyent/node-manta)

jclulow commented 7 years ago

Testing Notes

The change set is make check clean, and I ran make test against a Manta deployment with MPU enabled. All tests passed.

OK: 407 assertions (232695ms)

I also tested this against a Manta deployment without MPU, and that case is correctly detected and the tests are still skipped.

OK: 317 assertions (103507ms)
jclulow commented 7 years ago

Note that this change will be released together with a subsequent change (#326).