TritonDataCenter / node-manta

Node.js SDK for Manta
75 stars 54 forks source link

joyent/node-manta#290 Switch muntar over to use tar-stream #367

Open joyent-automation opened 5 years ago

joyent-automation commented 5 years ago

joyent/node-manta#290 Switch muntar over to use tar-stream

This PR was migrated-from-gerrit, https://cr.joyent.us/#/c/1037/. The raw archive of this CR is here. See MANTA-4594 for info on Joyent Eng's migration from Gerrit.

CR discussion

@trentm commented at 2016-12-02T23:17:46

Patch Set 1: Code-Review+1

Gah. I spent time scratching my head how dirs are handled by muntar then realized there is already https://github.com/joyent/node-manta/issues/259 for that (hint hint, if you want jperkin). :)

Code looks good to me and works with the couple tars I tried.

How do we decide we are comfortable enough to release this? tar-stream has some tests at least.